Skip to content

Update flightctl-base image#389

Merged
celdrake merged 1 commit into
flightctl:mainfrom
celdrake:update-flightctl-base-image
Nov 27, 2025
Merged

Update flightctl-base image#389
celdrake merged 1 commit into
flightctl:mainfrom
celdrake:update-flightctl-base-image

Conversation

@celdrake

@celdrake celdrake commented Nov 27, 2025 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

Updates the flightctl-base image to the same version as the flightctl repository.
See flightctl/flightctl#2071

Summary by CodeRabbit

  • Chores
    • Updated runtime base image from version 9.6 to 9.7 for improved stability and security.
    • Bumped a module dependency to v1.0.0-rc1 to align with the newer release stream.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitai Bot commented Nov 27, 2025 •
edited
Loading

Copy link
Copy Markdown

Warning

Rate limit exceeded

@celdrake has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 1 minutes and 41 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 467c9fb and 13e36ae.

⛔ Files ignored due to path filters (1)
  • proxy/go.sum is excluded by !**/*.sum
📒 Files selected for processing (5)
  • Containerfile (1 hunks)
  • Containerfile.ocp (1 hunks)
  • proxy/auth/aap.go (2 hunks)
  • proxy/auth/auth.go (1 hunks)
  • proxy/go.mod (1 hunks)

Walkthrough

Updated two container build files to use a newer base image tag (9.6 → 9.7) and bumped a Go module dependency for github.com/flightctl/flightctl from a commit-based pseudo-version to v1.0.0-rc1. No other code or build steps changed.

Changes

Cohort / File(s) Summary
Base image version update
Containerfile, Containerfile.ocp		 Updated base image tag from quay.io/flightctl/flightctl-base:9.6-1762316544 to quay.io/flightctl/flightctl-base:9.7-1762965531. All other instructions unchanged.
Go module version bump
proxy/go.mod		 Changed require entry for github.com/flightctl/flightctl from v1.0.0-main.0.20251125075421-bbc6daa7c2e7 to v1.0.0-rc1. No other dependency edits.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Review proxy/go.mod change for intended API/behavior differences and run go mod tidy / go test.
  • Verify container images build and behave the same in CI for Containerfile and Containerfile.ocp.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Update flightctl-base image' directly and clearly describes the main change in the PR, which is updating the base image tag in Containerfile and Containerfile.ocp files from version 9.6 to 9.7.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@celdrake celdrake force-pushed the update-flightctl-base-image branch 2 times, most recently from 467c9fb to 5792134 Compare November 27, 2025 08:16
celdrake
celdrake commented Nov 27, 2025
View reviewed changes
Comment thread proxy/auth/aap.go
authURL := aapSpec.ApiUrl
if aapSpec.ExternalApiUrl != nil && *aapSpec.ExternalApiUrl != "" {
authURL = *aapSpec.ExternalApiUrl
if aapSpec.ClientId == "" {

@celdrake celdrake Nov 27, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to clean-up the other providers since we're now using the API endpoints for all of them, but for now I made the changes so the code compiles correctly.

@celdrake celdrake force-pushed the update-flightctl-base-image branch from 5792134 to 13e36ae Compare November 27, 2025 08:24
@celdrake celdrake merged commit f42047f into flightctl:main Nov 27, 2025
6 checks passed
@celdrake celdrake deleted the update-flightctl-base-image branch November 27, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rawagner rawagner rawagner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@celdrake @rawagner